Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shortfin] Bump IREE dep to iree-3.1.0rc20241204. #635

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

ScottTodd
Copy link
Member

@ScottTodd ScottTodd commented Dec 3, 2024

Diff: iree-org/iree@iree-3.0.0rc20241118...iree-3.1.0rc20241204

Notable changes that could affect shortfin:

This update (particularly the last commit there) fixes #534 (the Windows build was broken).

@ScottTodd ScottTodd marked this pull request as ready for review December 3, 2024 16:58
@ScottTodd ScottTodd requested review from marbre and monorimet December 3, 2024 16:58
@ScottTodd
Copy link
Member Author

Workflow failures appear to be preexisting and unrelated to this change:

Workflow name Workflow file logs on this PR history on main
CI - sharktank perplexity short / Llama3.1 8B FP16 (3.11, llama-mi300x-3) https://github.com/nod-ai/shark-ai/blob/main/.github/workflows/ci_eval_short.yaml logs here history here
Llama Benchmarking 8B Tests / Llama Benchmarking 8B Tests (3.11) https://github.com/nod-ai/shark-ai/blob/main/.github/workflows/ci-llama-quick-tests.yaml logs here history here

(or the deps pinning is broken in such a way that this destabilized those workflows on the main branch... but that needs to be fixed regardless)

Copy link
Collaborator

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ScottTodd! Great to see the Windows build fixed by your upstream commits. Build failures seem unrelated.

@ScottTodd ScottTodd changed the title [shortfin] Bump IREE dep to iree-3.1.0rc20241203. [shortfin] Bump IREE dep to iree-3.1.0rc20241204. Dec 4, 2024
@ScottTodd ScottTodd mentioned this pull request Dec 4, 2024
@ScottTodd
Copy link
Member Author

Workflows are passing now, except for a new test regression on Windows. Commented at #632 (comment). May just merge this since this gets the Windows build passing at least.

@ScottTodd ScottTodd merged commit 466c6fe into nod-ai:main Dec 4, 2024
18 of 20 checks passed
@ScottTodd ScottTodd deleted the bump-iree-3.1.0rc20241203 branch December 4, 2024 17:40
monorimet pushed a commit that referenced this pull request Dec 13, 2024
Diff:
iree-org/iree@iree-3.0.0rc20241118...iree-3.1.0rc20241204

Notable changes that could affect shortfin:

*
iree-org/iree@cd4aa72
"[runtime][python] Fix device array deepcopy when not mappable"
*
iree-org/iree@ef4ecf3
"[iree.build] Wire up out of process concurrency."
*
iree-org/iree@516ff10
"[python] Overhaul iree.build console output and error handling."
*
iree-org/iree@9789438
"[iree.build] Make the fetch_http action more robust."
*
iree-org/iree@006c5d8
"Avoid compound literal struct init for better C/C++ compat."

This update (particularly the last commit there) fixes
#534 (the Windows build was
broken).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[shortfin] Windows builds failing when compiling compound literals
3 participants