Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tuner]: use python binding to select mma intrinsics #586

Merged
merged 4 commits into from
Nov 22, 2024
Merged

[tuner]: use python binding to select mma intrinsics #586

merged 4 commits into from
Nov 22, 2024

Conversation

bangtianliu
Copy link
Contributor

This PR is relevant to the task in #453: " Use IREE attributes for MFMA intrinsics in the tuner".

kuhar
kuhar requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI doesn't pass -- seems like the code doesn't type check

tuner/tuner/candidate_gen.py Outdated Show resolved Hide resolved
tuner/tuner/common.py Outdated Show resolved Hide resolved
tuner/tuner/dispatch_constraints.py Outdated Show resolved Hide resolved
tuner/tuner/dispatch_constraints.py Outdated Show resolved Hide resolved
tuner/tuner/common.py Outdated Show resolved Hide resolved
@kuhar kuhar mentioned this pull request Nov 22, 2024
Closed
12 tasks
@bangtianliu bangtianliu requested a review from kuhar November 22, 2024 02:05
kuhar
kuhar reviewed Nov 22, 2024
View reviewed changes
tuner/tuner/common.py Outdated Show resolved Hide resolved
tuner/tuner/common_test.py Outdated Show resolved Hide resolved
kuhar
kuhar reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test that shows that filtering based on available intrinsics works in get_compatible_mfma_intrinsics

tuner/tuner/dispatch_constraints_test.py Outdated Show resolved Hide resolved
@bangtianliu
[tuner]: add the tests
4860891 
Signed-off-by: Bangtian Liu <[email protected]>
@bangtianliu bangtianliu requested a review from kuhar November 22, 2024 16:17
@kuhar kuhar merged commit 530f4bd into nod-ai:main Nov 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhar kuhar kuhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bangtianliu @kuhar