Build nightly shark-ai -package #535
Conversation
There was a problem hiding this comment.
- Can you run this on your fork and share the resulting outputs so we can test?
- Is the nightly
shark-aiwhl ready to promote to pypi with just droppingrcYYYYMMDDfrom its own version, or are deeper changes to the package needed for that?
There was a problem hiding this comment.
The generated requirements file would still be different:
requirements.txtfor nightly release
iree-base-compiler
iree-base-runtime
iree-turbine
shortfin==3.0.0rc20241115
stable.txtfor nightly release
iree-base-compiler==3.0.*
iree-base-runtime==3.0.*
iree-turbine==3.0.*
shortfin==3.0.0
There was a problem hiding this comment.
Running on my fork, you get the following releases (screenshot):
The METADATA for the SHARK AI meta package is
Metadata-Version: 2.1
Name: shark-ai
Version: 2.9.2rc20241118
Summary: SHARK AI meta package
Author: SHARK Authors
License: Apache-2.0
Project-URL: Repository, https://github.com/nod-ai/shark-ai
Classifier: Development Status :: 3 - Alpha
Classifier: License :: OSI Approved :: Apache Software License
Classifier: Programming Language :: Python :: 3
Description-Content-Type: text/markdown
Requires-Dist: iree-base-compiler
Requires-Dist: iree-base-runtime
Requires-Dist: iree-turbine
Requires-Dist: shortfin==2.9.2
Provides-Extra: apps
Requires-Dist: shortfin[apps]; extra == "apps"
Provides-Extra: onnx
Requires-Dist: iree-base-compiler[onnx]; extra == "onnx"
# SHARK AI meta package
Meta package to install `shortfin` and compatible IREE packages.
There was a problem hiding this comment.
What would it take to make a nightly SHARK AI be directly promotable to PyPI? I want consistency and predictability for packaging, so users can switch channels easily and release engineers can follow simple steps without needing to think too hard about special cases.
There was a problem hiding this comment.
I'd need to look into what the current scripts do, but as a wheel essentially is just a zip-file, we probably can unpack (ourselves?) to edit the Requires-Dist:entries in the METADATA file (and update the hash in RECORDafterwards).
This adds `iree-base-compiler`, `iree-base-runtime` and `iree-turbine` as dependencies written to the generated `requirements.txt` for nighly builds. Note that no explicit versions get pinned as it is the case for stable releases! Rational behind is that the versions might not align as it is required for stable releases.
The sharktank package was temporarily removed from the dependencies.
marbre
force-pushed
the
shark-ai-nightly
branch
from
880cb30 to
8de1378
Compare
Refactors the scripts so that a version suffix can be passed as an argument. This is used to generate the suffix only once in the workflow instead of computing it in multiple scripts and partly scattered across different steps (
write_requirements.pyruns in a different step). Further adds dependencies to IREE packages also for nightly shark-ai builds.Requires #519.