[KernelDispatch] Refactor the pass for generic ops and utils for matmul_transpose_b ops #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhang93
requested review from
MaheshRavishankar,
nirvedhmeshram,
Abhishek-Varma and
jtuyls
as code owners
jtuyls
approved these changes
Dec 17, 2024
Comment on lines
110
to
112
| if (!bodyMatcherForMatmulLikeOps(yieldVal, body)) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (!bodyMatcherForMatmulLikeOps(yieldVal, body)) { | |
| return false; | |
| } | |
| if (!bodyMatcherForMatmulLikeOps(yieldVal, body)) return false; |
| @@ -215,6 +234,22 @@ bool isMatmul(linalg::LinalgOp linalgOp) { | |||
| match6DLinalgGenericMatmul(linalgOp); | |||
| } | |||
|
|
|||
| /// Utility to indentify whether a linalg op is a matmul_transpose_b op. | |||
There was a problem hiding this comment.
Suggested change
| /// Utility to indentify whether a linalg op is a matmul_transpose_b op. | |
| /// Utility to identify whether a linalg op is a matmul_transpose_b op. |
| @@ -48,6 +48,9 @@ FailureOr<unsigned> getTilingScaleFactor(Type elemType); | |||
| /// Utility to indentify whether a linalg op is a matmul op. | |||
| bool isMatmul(linalg::LinalgOp linalgOp); | |||
|
|
|||
| /// Utility to indentify whether a linalg op is a matmul_transpose_b op. | |||
There was a problem hiding this comment.
Suggested change
| /// Utility to indentify whether a linalg op is a matmul_transpose_b op. | |
| /// Utility to identify whether a linalg op is a matmul_transpose_b op. |
jtuyls
changed the title
yzhang93
force-pushed
the
refactor_kernel_dispatch
branch
from
24e0320 to
10a33ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactored and simplified the root config setting in
KernelDispatch.cppfor the following aspects:setTransposeLikeOpRootConfigand flagisMatmulTranspseB. Instead, directly go throughsetRootConfigfor generic version as well as the named op version ofmatmul_transpse_b. This will be easier when we extend the support to covermatmul_transpose_a.isMatmulTransposeButils toUtils.cppand reuse/merge with the existing utils for matmul ops.matmulandmatmul_transpose_b.