[CombineStridedOps] Generalize dimension checking #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtuyls
requested review from
MaheshRavishankar,
nirvedhmeshram,
yzhang93 and
Abhishek-Varma
as code owners
jtuyls
force-pushed
the
combine-strided-ops-exceed-dims
branch
from
7ff116a to
75060e4
Compare
|
I guess this will solve #1036 What is the logic behind circular dma's being allowed unlimited dma dimensions? |
Answered privately: having unlimited is actually too lenient, but the thinking is that you can unlimited dimensions as long as they have stride = 0 (I guess because they can all be collapsed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes dimension checking in
CombineStridedOps. This allows difference ops to provide their own dimension checking implementation. This is needed because circular and non-circulardma_cpy_ndops have different logic for checking whether the number of dimensions of the combined DMA op would exceed the available number of dimensions.With this fix, BatchMatmul works with the
pack-peel-4-level-tilingpipeline.