[TargetCDODirect] Separate aie-rt related functions into a new library #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yu-Zhewen
requested review from
makslevental,
MaheshRavishankar,
nirvedhmeshram,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
jtuyls
reviewed
Jan 10, 2025
| // Licensed under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| #pragma once |
There was a problem hiding this comment.
Could you use the #ifndef IREE_AMD_AMDAIE_RT_H_ header guards instead in consistency with upstream?
| return failure(); | ||
| } | ||
|
|
||
| // pull metadata related to packet routing, bdid, buffer length, size, stride |
There was a problem hiding this comment.
Suggested change
| // pull metadata related to packet routing, bdid, buffer length, size, stride | |
| // Pull metadata related to packet routing, bdId, buffer length, size, stride |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following interface functions between the
xilinx::aiedialect andaie-rthave been relocated and renamedTarget/AMDAIETargetCDODirect.cpp/addAieElfsToCDO->Target/AMDAIERT.cpp/addAllAieElfsTarget/AMDAIETargetCDODirect.cpp/addCoreEnableToCDO->Target/AMDAIERT.cpp/addAllCoreEnableTarget/AMDAIETargetCDODirect.cpp/addInitConfigToCDO->Target/AMDAIERT.cpp/addInitConfigThe motivation is, these functions are not specific to the CDO and can be useful in other contexts, such as generating control packets.
Brief documentation has also been added for these functions in the new header file.
related: Xilinx/mlir-aie#1760