Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test project which finds and validates CMake packages and config. #71

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

stellaraccident
Copy link
Contributor

@stellaraccident stellaraccident commented Feb 6, 2025

Includes changes needed to get the packaging working and passing a test.

  • Add a base/aux-overlay that populates some structural files that don't belong to any project:
    • CMake package redirection in the root lib/cmake directory to packages in the lib/llvm/lib/cmake directory (so that users only need to specify one CMAKE_PREFIX_PATH).
    • An llvm -> lib/llvm symlink to account for an old directory organization that is still required in some cases (should be removed soon in favor of fixing upstream).
  • Add default_patterns boolean to artifact component descriptors, disabling the use of default includes/excludes for a component.
  • Build therock-dist(-.+)? as part of ALL.
  • Adds amd-comgr and hipcc to the amd-llvm artifact bundle (was an oversight before).
  • Includes hipBLAS-common in the blas artifact bundle (was an oversight before).

Fixes #38

@stellaraccident stellaraccident force-pushed the validate_cmake_packages branch from b37d422 to 2148cda Compare February 7, 2025 00:30
@stellaraccident stellaraccident marked this pull request as ready for review February 7, 2025 01:56
@stellaraccident stellaraccident merged commit 6ebf3e3 into main Feb 7, 2025
1 check passed
@stellaraccident stellaraccident deleted the validate_cmake_packages branch February 7, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example project on the right way to take a dependency on HIP
2 participants