Patch rocm-core to be more compatible with Windows/MSVC. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
commented
Jan 31, 2025
patches/rocm-6.3.1/rocm-core/0001-Patch-version-and-getpath-files-to-be-compatible-wit.patch
Outdated
Show resolved
Hide resolved
ScottTodd
force-pushed
the
windows-rocm-core
branch
from
3f82af0 to
6f52c8f
Compare
stellaraccident
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #36, making a larger portion of https://github.com/ROCm/rocm-core/ compile on Windows.
About the changes
link.handdlfcn.hheaders do not exist on Windows and are only used whenBUILD_SHARED_LIBSis set.PATH_MAXvalue, defined inlimits.h, does not exist on Windows. I opted to use a fixed constant value of4096, butFILENAME_MAXis also an option (see https://stackoverflow.com/a/65174437).__attribute__((visibility("default")))do not exist on all compilers. Added some boilerplate cross platform versions (different approaches are possible too, this is just what I use on other projects).How I generated the patch
Made changes in the source folder
Committed to a branch (ScottTodd/rocm-core@0dd798f)
Ran