chore: Set default version from VERSION file #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrolikiewicz
approved these changes
Mar 29, 2024
BSski
pushed a commit
that referenced
this pull request
May 7, 2024
## Motivation If `sloctl` is installed through `go install` command it won't have the version set through build tags as we don't have any control over it. While it is possible to automate the process of updating the version we should currently just go with a manual, pre-release step to update VERSION file to the version we want to release. ## Testing Run `make build`, assert the output of `bin/sloctl version` is `sloctl/v0.0.99-- (linux amd64 go1.22.1)`. Run `LDFLAGS="-X $(go list -m)/internal.BuildVersion=v0.1.0" make build`, assert the output of `bin/sloctl version` is `sloctl/v0.1.0-- (linux amd64 go1.22.1)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If
sloctlis installed throughgo installcommand it won't have the version set through build tags as we don't have any control over it. While it is possible to automate the process of updating the version we should currently just go with a manual, pre-release step to update VERSION file to the version we want to release.Testing
Run
make build, assert the output ofbin/sloctl versionissloctl/v0.0.99-- (linux amd64 go1.22.1).Run
LDFLAGS="-X $(go list -m)/internal.BuildVersion=v0.1.0" make build, assert the output ofbin/sloctl versionissloctl/v0.1.0-- (linux amd64 go1.22.1).