chore: Fix bats tests #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With the changes introduced to
sloctl versioncommand in #304we no longer have the embedded sloctl version from
VERSIONfile as fallback.Instead, we're inferring the version (if it was not set during build time) using
runtime/debugpackage.This works fine, except for scenarios where we build sloctl binary without the version.
One instance of such usage are bats e2e tests.
Due to that, and the fallback version being
0.0.0the API was not returning the AWS IAM id for data export as it only returns it for sloctl versionv0.0.94and higher.Summary
Version is now set for all Makefile build commands, it is inferred from the current latest git tag and a build suffix is added, which will look like this:
0.12.0-test.Testing
Run the e2e tests.
Dispatched tests run: https://github.com/nobl9/sloctl/actions/runs/13819778124/job/38662027117.
The run failed on another step cause I cancelled the run before this run and it left dangling resources.