feat: Extend release targets and add install.bash script #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-and-add-install-script
…s-and-add-install-script
skrolikiewicz
approved these changes
Feb 21, 2025
nieomylnieja
force-pushed
the
extend-release-targets-and-add-install-script
branch
from
13f661f to
e4e44ac
Compare
nieomylnieja
force-pushed
the
extend-release-targets-and-add-install-script
branch
from
e4e44ac to
47280e1
Compare
|
Tested on Windows 11 23h2 with Cygwin: |
nieomylnieja
deleted the
extend-release-targets-and-add-install-script
branch
nieomylnieja
added a commit
that referenced
this pull request
Feb 24, 2025
Changes introduced in #288 broke this glob pattern: ```ruby bin.install Dir['sloctl-*-0.11.0'].first() => "sloctl" ``` Since this is not a regular expression but a glob pattern, the newly added arch suffix (and the moved OS name) failed to match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we're only building binaries for amd64 architecture, it would be good to support arm64 as well.
In addition, many tools often provide an install script which automates the process of installing/upgrading these tools.
Testing
Run install script:
You can also test the commands for installment from README, for instance:
Release Notes
Sloctl pre-built binaries are now also built for arm64 architecture.
In addition there's now a now method of installing sloctl, via an install script.
For more details refer to the README.
Breaking Changes
Sloctl released binaries are no longer of a form sloctl-${OS}-${VERSION} (e.g.
sloctl-linux-0.10.1), instead they now follow this pattern: _sloctl-${VERSION}-${OS}-${ARCH} (e.g.sloctl-0.11.0-linux-adm64).In addition, the checksum for each release is changing it's name from _sloctl-${VERSION}-SHA256SUMS to sloctl-${VERSION}.sha256.