Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a small UNIX bug where the JSON output was getting managed by errors on stdout #280

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

prologic
Copy link
Contributor

No description provided.

@prologic prologic marked this pull request as ready for review January 30, 2025 03:48
Copy link

@karolba karolba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@karolba karolba merged commit cbd2f10 into nobl9:main Feb 3, 2025
4 of 5 checks passed
nieomylnieja added a commit that referenced this pull request Feb 3, 2025
@nieomylnieja
Copy link
Contributor

nieomylnieja commented Feb 3, 2025

hey @prologic :) first of all, thanks for the contribution!
Unfortunately the approve on this one was a bit rushed, we can't introduce this change because it is a breaking change.
Users could be relying on the fact that the stdout contains these messages.
I agree the current behavior is not ideal, but our main focus with a widely adopted and long lived project like this one is to keep backward compatibility first.

That being said we'd love to help you solve your use case, one potential solution is to add a configuration setting to sloctl which would allow you to redirect these outputs to stderr.
Let me know what you think!

@prologic
Copy link
Contributor Author

prologic commented Feb 4, 2025

No problems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants