Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PC-14244 Add flag to filter SLOs by service #264

Merged
merged 8 commits into from
Jan 16, 2025
Merged

feat: PC-14244 Add flag to filter SLOs by service #264

merged 8 commits into from
Jan 16, 2025

Conversation

BSski
Copy link
Contributor

@BSski BSski commented Dec 20, 2024 •
edited by nieomylnieja
Loading

Release Notes

Added filtering SLOs by service name. Example: sloctl get slo -s my-service or sloctl get slo --service=my-service.

@BSski BSski changed the title PC-14244 Add flag to filter SLOs by service feat: PC-14244 Add flag to filter SLOs by service Dec 20, 2024
@n9-machine-user n9-machine-user added go enhancement New feature or request minor labels Dec 20, 2024
@nieomylnieja nieomylnieja marked this pull request as ready for review January 8, 2025 14:04
@nieomylnieja nieomylnieja self-requested a review as a code owner January 8, 2025 14:04
@daniel-zelazny daniel-zelazny self-requested a review January 10, 2025 10:52
daniel-zelazny
daniel-zelazny approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@daniel-zelazny daniel-zelazny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@daniel-nobl9 daniel-nobl9 added the passed-testing Added by QA when tests have passed label Jan 13, 2025
@nieomylnieja nieomylnieja enabled auto-merge (squash) January 16, 2025 11:05
@nieomylnieja nieomylnieja merged commit 526c6bf into main Jan 16, 2025
5 checks passed
@nieomylnieja nieomylnieja deleted the PC-14244-add-filtering-slos-by-service-flag branch January 16, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-zelazny daniel-zelazny daniel-zelazny approved these changes

@nieomylnieja nieomylnieja Awaiting requested review from nieomylnieja nieomylnieja is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request go minor passed-testing Added by QA when tests have passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BSski @daniel-zelazny @nieomylnieja @daniel-nobl9 @n9-machine-user