Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Disable adding offset to From when queuing replays #255

Merged
merged 8 commits into from
Dec 5, 2024
Merged

chore: Disable adding offset to From when queuing replays #255

merged 8 commits into from
Dec 5, 2024

Conversation

greg-agacinski
Copy link
Member

Summary

Disable adding offset to From when queuing replays

@paulina-n9
Copy link
Contributor

  • Once playlists are enabled, the 20-minute offset is no longer added. The offset remains for organizations without playlists.
Zrzut ekranu 2024-12-5 o 09 48 09 Zrzut ekranu 2024-12-5 o 10 51 56
  • The from parameter has been fixed:
Zrzut ekranu 2024-12-5 o 09 47 28
  • I've also run regression tests to ensure that the behavior of the sloctl apply and sloctl replay commands remains unchanged.
Zrzut ekranu 2024-12-5 o 10 10 48 Zrzut ekranu 2024-12-5 o 09 58 49

@paulina-n9 paulina-n9 added the passed-testing Added by QA when tests have passed label Dec 5, 2024
bdw-nobl9
bdw-nobl9 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@bdw-nobl9 bdw-nobl9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a single suggestion. The rest of the code - ✅

bdw-nobl9
bdw-nobl9 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@bdw-nobl9 bdw-nobl9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve after code review changes.

@greg-agacinski greg-agacinski merged commit ea7646e into main Dec 5, 2024
5 checks passed
@greg-agacinski greg-agacinski deleted the PC-14873 branch December 5, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdw-nobl9 bdw-nobl9 bdw-nobl9 approved these changes

@nieomylnieja nieomylnieja Awaiting requested review from nieomylnieja nieomylnieja is a code owner

Assignees
No one assigned
Labels
chore go passed-testing Added by QA when tests have passed patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@greg-agacinski @paulina-n9 @bdw-nobl9 @n9-machine-user