feat: Improve flags handling [PC-13534] #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nieomylnieja
changed the title
n9-machine-user
added
breaking-change
enhancement
…com:nobl9/sloctl into PC-13534-disallow-A-flag-for-delete-by-name
nieomylnieja
added a commit
that referenced
this pull request
Aug 12, 2024
## Motivation Alerts, while not directly Project scoped, support Project filtering. With the changes introduced in #177, the flag was removed. This PR brings it back. ## Testing Build sloctl with `make build` locally and run `sloctl get alert -A` and `sloctl get alert -p <project_name>`. ## Release Notes `sloctl get alert` once again supports both `-p` and `-A` flags for Project filtering. These flags were removed as a regression in v0.4.0.
nieomylnieja
added a commit
that referenced
this pull request
Aug 20, 2024
#177 removed default project flags, unfortunately we missed the `sloctl replay` command which also relied on them. This PR brings the `-p` flag back for `sloctl replay` command. --------- Co-authored-by: Tomek Labuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For a long time
sloctlhad-pand-Aflags available in the global scope, even if specific sub-commands were not using it.Similarly,
-lflag forget <object>command was available even for objects which do not support labels filtering.This PR finally fixes these issues and sets the aforementioned flags contextually, only when it makes sense.
Testing
-pflag usage works for project scoped objects ondelete(by name) andgetcommands.-Aflag is only visible/usable forgetcommand for project scoped objects, and that it works.-lflag for labels filtering is only visible for objects supporting labels, and that it works.Successful run: https://github.com/nobl9/sloctl/actions/runs/10200396849/job/28219757765
Breaking Changes
getcommand exposes-lflag for objects which support labels filtering, in addition-pand-Aflags are now only available for Project scoped objects.delete <name>command no longer supports-Aflag and supports-pflag only for Project scoped objects.get alertcommand now prints No resources found. notice, just like the rest ofget <object>commands.