Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing stderr from assert_success output #176

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

nieomylnieja
Copy link
Contributor

Since we introduced run --separate-stderr flag some time ago in order to avoid assert_output checking both stdout and stderr (which can contain stuff like "retrying" notices) and failing due to that, it had a side effect on assert_success, which now only prints $output which is only stdout (stderr is separated into $stderr).

To fix that we need to give assert_success conjoined stdout and stderr.

@n9-machine-user n9-machine-user added bug Something isn't working patch labels Jul 31, 2024
@nieomylnieja nieomylnieja merged commit b16f345 into main Aug 1, 2024
6 checks passed
@nieomylnieja nieomylnieja deleted the fix-bats-tests-missing-stderr branch August 1, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants