fix: Add missing stderr from assert_success output #176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we introduced
run --separate-stderr
flag some time ago in order to avoidassert_output
checking both stdout and stderr (which can contain stuff like "retrying" notices) and failing due to that, it had a side effect onassert_success
, which now only prints$output
which is only stdout (stderr is separated into$stderr
).To fix that we need to give
assert_success
conjoined stdout and stderr.