Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Separate stderr from stdout in the tests #167

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

nieomylnieja
Copy link
Contributor

Motivation

Currently, whenever sloctl logs something to stderr, like Retrying logs, it will fail the tests because assert_output is checking $output variable set by run function of bats framework. The $output contains both stderr and stdout. Fortunately, there's a flag for run --> --separate-stderr which does the job and separates both outputs into different variables.

Copy link
Member

@skrolikiewicz skrolikiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nieomylnieja nieomylnieja merged commit f599570 into main Jul 18, 2024
6 checks passed
@nieomylnieja nieomylnieja deleted the fix-tests-stderr-handling branch July 18, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants