Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct labels usage in Report object #655

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

nieomylnieja
Copy link
Collaborator

@nieomylnieja nieomylnieja commented Feb 27, 2025

Motivation

Report object was redefining v1alpha.Labels instead of using it.

Summary

Fixed some minor issues reported by gopls.

Breaking Changes

report.Labels, report.LabelKey and report.LabelValue have been removed, use v1alpha.Labels instead.

@n9-machine-user n9-machine-user added breaking-change We're breaking the API bug Something isn't working go patch labels Feb 27, 2025
Copy link
Member

@skrolikiewicz skrolikiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏷️ 🚀

@nieomylnieja nieomylnieja merged commit 5a26c24 into main Feb 28, 2025
9 checks passed
@nieomylnieja nieomylnieja deleted the correct-report-labels branch February 28, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change We're breaking the API bug Something isn't working go patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants