fix: Double quoted JSON handling #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nieomylnieja
requested review from
skrolikiewicz and
daniel-zelazny
as code owners
BSski
approved these changes
Jun 27, 2024
nieomylnieja
added a commit
to nobl9/sloctl
that referenced
this pull request
Jun 27, 2024
## Related changes - nobl9/nobl9-go#471 ## Release Notes Fixed incorrect handling of double quoted JSON literals which caused errors when unmarshaling CloudWatch v1alpha SLOs with certain `json` queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The issue is extensively covered in this issue: goccy/go-yaml#455
Summary
Added test case and replaced
goccy/go-yamlwith our fork.For now I'm pinning the commit SHA from the PR branch.
I'm not sure if the upstream is actively maintained anymore, we might just want to go further with the fork instead of the replace clause.
Related changes
Testing
Test case was supplied.
Release Notes
Fixed incorrect handling of double quoted JSON literals which caused errors when unmarshaling CloudWatch v1alpha SLOs
with certain
jsonqueries.