Fixes cemerick#19 - Prevent sorting of query params blowing up when s…

…tring and keyword keys are used. Add test case.
no-man-is-an-island · Jan 7, 2016 · 9b98caa · 9b98caa
1 parent a785b84
commit 9b98caa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/cemerick/url.cljx b/src/cemerick/url.cljx
@@ -29,11 +29,11 @@
 (defn map->query
   [m]
   (some->> (seq m)
-    sort                     ; sorting makes testing a lot easier :-)
     (map (fn [[k v]]
            [(url-encode (name k))
             "="
             (url-encode (str v))]))
+    sort                     ; sorting makes testing a lot easier :-)
     (interpose "&")
     flatten
     (apply str)))

diff --git a/test/cemerick/test_url.cljx b/test/cemerick/test_url.cljx
@@ -11,6 +11,7 @@
 (deftest test-map-to-query-str
   (are [x y] (= x (map->query y))
        "a=1&b=2&c=3" {:a 1 :b 2 :c 3}
+       "a=1&b=2&c=3" {:a 1 "b" 2 :c 3}
        "a=1&b=2&c=3" {:a "1"  :b "2" :c "3"}
        "a=1&b=2" {"a" "1" "b" "2"}
        "a=" {"a" ""}))