[android] Add llama2 example #359
Conversation
niley7464
requested review from
jaeyun-jung,
myungjoo,
again4you,
leemgs,
wooksong,
gichan-jang and
anyj0527
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #359. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
|
|
cibot:
|
|
|
|
There was a problem hiding this comment.
@niley7464, 💯 All CI checkers are successfully verified. Thanks.
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:tools="http://schemas.android.com/tools"> | ||
| <queries> | ||
| <package android:name="ai.nnstreamer.ml.inference.offloading" /> |
There was a problem hiding this comment.
This part can make android application to call another application's service
https://developer.android.com/training/package-visibility/declaring
| @@ -0,0 +1,137 @@ | |||
| package com.example.llama2 | |||
There was a problem hiding this comment.
Most other examples have the same package name, package org.freedesktop.gstreamer.nnstreamer;.
Q1. Is it OK with the same package names in the same repository? (I don't know)
Q2. There is nothing wrong with com.example.llama2 but how about using our domain ai.nnstreamer.example.llama2 ?
There was a problem hiding this comment.
Or ```nnstreamer.example`.*``?
There was a problem hiding this comment.
A1. example_app's settings.gradle does not have llama2 in include directory, so I don't think there will be a problem
But it looks something weired. How about make another example_app directory for NNS-android?
android/example_app, android/kotlin_app (or something else)
A2. I will update the package name after separate the repository 😊
There was a problem hiding this comment.
Updated package name to ai.nnstreamer.example.llama2 and separated the repo
There was a problem hiding this comment.
@niley7464, 💯 All CI checkers are successfully verified. Thanks.
|
|
|
|
|
|
This patch adds android application example to use llama2 model. To use this application, nnstreamer-android's service application must be installed to the target device. Signed-off-by: Yelin Jeong <[email protected]>
There was a problem hiding this comment.
@niley7464, 💯 All CI checkers are successfully verified. Thanks.
This patch adds android application example to use llama2 model.
To use this application, nnstreamer-android's service application must be installed to the target device.
Self evaluation: