Skip to content
This repository has been archived by the owner on Nov 28, 2024. It is now read-only.

CNV-39752: Button to expand all sections #97

Merged
merged 1 commit into from
Mar 22, 2024
Merged

CNV-39752: Button to expand all sections #97

merged 1 commit into from
Mar 22, 2024

Conversation

upalatucci
Copy link
Collaborator

Screenshot from 2024-03-21 14-56-16
Screenshot from 2024-03-21 14-56-13

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 21, 2024 •
edited by openshift-ci bot
Loading

@upalatucci: This pull request references CNV-39752 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Screenshot from 2024-03-21 14-56-16
Screenshot from 2024-03-21 14-56-13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from tnisan and yaacov March 21, 2024 13:56
@metalice
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 22, 2024
@openshift-ci openshift-ci bot removed the lgtm label Mar 22, 2024
hstastna
hstastna approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@hstastna hstastna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, conflicts resolved, nice work, Ugo! :)

@openshift-ci openshift-ci bot added the lgtm label Mar 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b2b2563 into nmstate:main Mar 22, 2024
3 checks passed
This was referenced Mar 28, 2024
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hstastna hstastna hstastna approved these changes

@tnisan tnisan Awaiting requested review from tnisan

@yaacov yaacov Awaiting requested review from yaacov

Assignees

@hstastna hstastna

@metalice metalice

Labels
approved jira/valid-reference lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@upalatucci @openshift-ci-robot @metalice @hstastna @openshift-merge-robot