Upgrade to Patternfly 5 and SDK 1.1.0 #94
Conversation
upalatucci
force-pushed
the
patternfly-5
branch
from
4f95d51 to
3684cdb
Compare
upalatucci
force-pushed
the
patternfly-5
branch
from
3684cdb to
3bd845d
Compare
upalatucci
changed the title
upalatucci
force-pushed
the
patternfly-5
branch
from
3bd845d to
74f1a7e
Compare
|
@upalatucci It looks good to me, but I'll let Aviv and Matan review it first since they dealt with the upgrades on kubevirt-plugin. |
| import { MenuToggle, MenuToggleElement, MenuToggleProps } from '@patternfly/react-core'; | ||
|
|
||
| const DropdownToggle = ({ children, ...props }: MenuToggleProps) => | ||
| function DToggle(toggleRef: Ref<MenuToggleElement>) { |
There was a problem hiding this comment.
why mixing both arrow function and native function syntax? Please stick with arrow function notation
There was a problem hiding this comment.
I transformed the inside arrow function into a native function as typescript error raise about react component without displayName
upalatucci
force-pushed
the
patternfly-5
branch
6 times, most recently
from
36817a6 to
ec67fb0
Compare
upalatucci
force-pushed
the
patternfly-5
branch
from
ec67fb0 to
7fb5ffb
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
upgrade to patternfly 5
openshift console webpack 1.0.1
openshft console SDK 1.1.0 (to get the rowSearchFilters)