Skip to content
This repository has been archived by the owner on Nov 28, 2024. It is now read-only.

CNV-36299: Sort by name NNS #87

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

upalatucci
Copy link
Collaborator

@upalatucci upalatucci commented Dec 11, 2023

Sort NNS by name on toggle name column sort icon.

The table is not the VirtualizedTable as it does not support the automatic sort. So we need to do it manually.

patternfly: https://v4-archive.patternfly.org/v4/components/table/#composable-sortable--wrapping-headers

Screenshot from 2023-12-11 11-17-12
Screenshot from 2023-12-11 11-17-08

@openshift-ci openshift-ci bot requested review from metalice and pcbailey December 11, 2023 10:18
@upalatucci upalatucci force-pushed the sort-nns-by-name branch 2 times, most recently from 7301580 to 903a9c9 Compare December 11, 2023 15:52
src/views/states/list/hooks/useSortStates.ts Outdated Show resolved Hide resolved
src/views/states/list/StatesList.tsx Outdated Show resolved Hide resolved
src/views/states/list/hooks/useSortStates.ts Outdated Show resolved Hide resolved
scripts/start-console.sh Outdated Show resolved Hide resolved
@upalatucci upalatucci changed the title Sort by name NNS CNV-36299: Sort by name NNS Dec 19, 2023
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 19, 2023

@upalatucci: This pull request references CNV-36299 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Sort NNS by name on toggle name column sort icon.

The table is not the VirtualizedTable as it does not support the automatic sort. So we need to do it manually.

patternfly: https://v4-archive.patternfly.org/v4/components/table/#composable-sortable--wrapping-headers

Screenshot from 2023-12-11 11-17-12
Screenshot from 2023-12-11 11-17-08

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@hstastna hstastna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, all the comments resolved. Approving! Good work!

Copy link
Contributor

openshift-ci bot commented Jan 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6357f97 into nmstate:main Jan 12, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants