-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
7301580
to
903a9c9
Compare
903a9c9
to
3269811
Compare
@upalatucci: This pull request references CNV-36299 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3269811
to
71c3b35
Compare
71c3b35
to
8b950ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, all the comments resolved. Approving! Good work!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sort NNS by name on toggle name column sort icon.
The table is not the
VirtualizedTable
as it does not support the automatic sort. So we need to do it manually.patternfly: https://v4-archive.patternfly.org/v4/components/table/#composable-sortable--wrapping-headers