Skip to content
This repository has been archived by the owner on Nov 28, 2024. It is now read-only.

OCPBUGS-42859: Interface with same name causes unexpected behavior in NNS topology #114

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

avivtur
Copy link
Collaborator

@avivtur avivtur commented Oct 8, 2024

name property under each interface is not unique, basing the id on the interface name can cause 2 interface with same name to have the same topology node id. this causes to have 2 nodes with same id which renders only one node to the screen which can change with no reason.

Before:
same-node-b4

After:
same-node-after

@openshift-ci-robot
Copy link
Collaborator

@avivtur: This pull request references Jira Issue OCPBUGS-42859, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

name property under each interface is not unique, basing the id on the interface name can cause 2 interface with same name to have the same topology node id. this causes to have 2 nodes with same id which renders only one node to the screen which can change with no reason.

Before:
same-node-b4

After:
same-node-after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@avivtur avivtur force-pushed the avoid-same-id-nodes branch from 8c44c1f to 2e5c532 Compare October 9, 2024 11:57
Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upalatucci
Copy link
Collaborator

/jira refresh

@openshift-ci-robot
Copy link
Collaborator

@upalatucci: This pull request references Jira Issue OCPBUGS-42859, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 19326ff into nmstate:main Oct 9, 2024
3 checks passed
@openshift-ci-robot
Copy link
Collaborator

@avivtur: Jira Issue OCPBUGS-42859: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42859 has been moved to the MODIFIED state.

In response to this:

name property under each interface is not unique, basing the id on the interface name can cause 2 interface with same name to have the same topology node id. this causes to have 2 nodes with same id which renders only one node to the screen which can change with no reason.

Before:
same-node-b4

After:
same-node-after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants