This repository has been archived by the owner on Nov 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avivtur
force-pushed
the
nns-topology
branch
9 times, most recently
from
August 14, 2024 22:08
0964cfc
to
a0dc8d6
Compare
avivtur
force-pushed
the
nns-topology
branch
8 times, most recently
from
August 19, 2024 10:32
4881e53
to
c1eba3c
Compare
avivtur
force-pushed
the
nns-topology
branch
4 times, most recently
from
August 19, 2024 13:46
232a7dc
to
87f6a5f
Compare
avivtur
force-pushed
the
nns-topology
branch
10 times, most recently
from
August 21, 2024 16:23
6b8fa99
to
38ca5fe
Compare
metalice
reviewed
Aug 21, 2024
metalice
reviewed
Aug 21, 2024
metalice
reviewed
Aug 21, 2024
metalice
reviewed
Aug 21, 2024
metalice
reviewed
Aug 21, 2024
metalice
reviewed
Aug 21, 2024
moreInfoURL?: string; | ||
}; | ||
|
||
export const DetailItemHeader: FC<DetailItemHeaderProps> = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why making such a genric component? cant split for 2 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also copied from kubevirt
metalice
reviewed
Aug 21, 2024
metalice
reviewed
Aug 21, 2024
Signed-off-by: Aviv Turgeman <[email protected]>
upalatucci
approved these changes
Aug 22, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/remove-lgtm |
Reviewed. For me it's great thanks aviv |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a first skeleton to the NNS topology, focusing on:
Enhancements to do/Issues to fix:
Demo:
NNS-topology-1.mp4