CNV-41292: Restricted page for test user on nns #103
Conversation
|
@upalatucci: This pull request references CNV-41292 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@upalatucci: This pull request references CNV-41292 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| message?: string; | ||
| }; | ||
|
|
||
| const AccessDenied: React.FC<AccessDeniedProps> = ({ message }) => { |
There was a problem hiding this comment.
Would you mind importing FC above like we do in the kubevirt-plugin repo? I think it's important to keep the same conventions in all repos we maintain.
|
Could you please add before and after screenshots since this PR creates visual changes? |
|
@upalatucci: This pull request references CNV-41292 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
upalatucci
force-pushed
the
nns-restricted
branch
from
7d5d669 to
89f98bd
Compare
|
/lgtm |
porting Access Denied component from console
show Access denied on 403
Before
After