Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmpolicy: Use nmstatectl policy instead of go lib #1277

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

nmpolicy: Use nmstatectl policy instead of go lib #1277

wants to merge 1 commit into from

Conversation

qinqon
Copy link
Member

@qinqon qinqon commented Dec 19, 2024 •
edited
Loading

What this PR does / why we need it:
The nmpolicies engine has being ported to nmstatectl policy, this change
replace the golang library by the nmstatectl policy so there is only one
implementation, later on the golang library will be archived.

Also this unblock support for numbers matching

Release note:

Replace golang nmpolicy lib with nmstatectl policy command.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L labels Dec 19, 2024
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qinqon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qinqon qinqon force-pushed the nmpolicy-rust branch 5 times, most recently from fc78de0 to 120d8b6 Compare January 2, 2025 16:11
@qinqon
Copy link
Member Author

qinqon commented Jan 3, 2025

/retest

@qinqon qinqon force-pushed the nmpolicy-rust branch 3 times, most recently from 298b9f3 to f005c19 Compare January 8, 2025 14:51
@qinqon qinqon changed the title wip nmpolicy: Use nmstatectl policy instead of go lib Jan 8, 2025
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 8, 2025
@qinqon qinqon requested review from mkowalski and removed request for yboaron and RamLavi January 8, 2025 14:52
@qinqon qinqon mentioned this pull request Jan 9, 2025
Open
@mkowalski mkowalski mentioned this pull request Jan 9, 2025
Open
@qinqon
Copy link
Member Author

qinqon commented Jan 9, 2025

/retest

@qinqon
nmpolicy: Use nmstatectl policy instead of go lib
fc42797 
The nmpolicies engine has being ported to nmstatectl policy, this change
replace the golang library by the nmstatectl policy so there is only one
implementation, later on the golang library will be archived.

Signed-off-by: Enrique Llorente <[email protected]>
@kubevirt-bot
Copy link
Collaborator

@qinqon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future fc42797 link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future
pull-kubernetes-nmstate-e2e-handler-k8s fc42797 link true /test pull-kubernetes-nmstate-e2e-handler-k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkowalski mkowalski Awaiting requested review from mkowalski

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qinqon @kubevirt-bot