-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extracting more key quantities #42
Merged
Merged
Changes from 20 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
ddb7c8d
first commit
sbreitbart-NOAA fa94b09
added period after end.year in template csv so that period is preserv…
sbreitbart-NOAA eb17968
Added notes and edits from Friday's coworking meeting. Notes explain …
sbreitbart-NOAA f0911ef
Small updates to broaden new fxn that inserts more key quantities- in…
sbreitbart-NOAA 92e98e0
Continue updating key quantities in write_captions and alt text/caps csv
sbreitbart-NOAA 34d21f8
first commit
sbreitbart-NOAA 231c142
Added notes and edits from Friday's coworking meeting. Notes explain …
sbreitbart-NOAA 29a83b0
Small updates to broaden new fxn that inserts more key quantities- in…
sbreitbart-NOAA e6d2762
Continue updating key quantities in write_captions and alt text/caps csv
sbreitbart-NOAA 400c298
Continue updating key quantities in write_captions and alt text/caps csv
sbreitbart-NOAA 6075458
Merge branch 'key-quants-2' of https://github.com/nmfs-ost/satf into …
sbreitbart-NOAA 2763323
Finished first working draft of add_more_key_quants fxn; updated alt …
sbreitbart-NOAA f484780
Small updates to fix regex matching
sbreitbart-NOAA ba4a93d
added new fxn (add_more_key_quants) to plotting fxns
sbreitbart-NOAA 8077ef2
updated add_more_key_quants fxn to handle two units (arguments) speci…
sbreitbart-NOAA aa6222f
minor update to test-plot_landings
sbreitbart-NOAA 4f2a362
-fixed bug in add_more_key_quants to allow str_replace_all to work ev…
sbreitbart-NOAA 42be843
Bring dependency and use of nmfspalette back into package
Schiano-NOAA 8cab783
Missed uncommenting + in code - resulted in failed tests
Schiano-NOAA e5e0c2b
coded more key quantities
sbreitbart-NOAA a1f3989
started "manual" vignette
sbreitbart-NOAA 442e89c
Changed projected biomass csv entry from figure to table; updated key…
sbreitbart-NOAA 24679ed
Started updating manual with documentation for new fxn
sbreitbart-NOAA b5dc676
fix(table_indices): add missing extract_caps_alttext argument
sbreitbart-NOAA 5ab2a8f
Finished updating new section in manual
sbreitbart-NOAA 59be9e1
Updating F-related key quantities' calculations
sbreitbart-NOAA a5191ee
Moving utils functions into their own .R files as an attempt towards …
sbreitbart-NOAA 9682059
Update manual to emphasize importance of checking/editing alt text
sbreitbart-NOAA b45412c
Created tests for new functions (export_rda and extract_caps_alttext)
sbreitbart-NOAA ac9bdd9
Updated calculation for landings plot's y axis max, since it's a stac…
sbreitbart-NOAA e731930
first commit
sbreitbart-NOAA 5042e73
Added notes and edits from Friday's coworking meeting. Notes explain …
sbreitbart-NOAA 007e0b7
Small updates to broaden new fxn that inserts more key quantities- in…
sbreitbart-NOAA 5ea8a4d
Continue updating key quantities in write_captions and alt text/caps csv
sbreitbart-NOAA 5c67b30
Continue updating key quantities in write_captions and alt text/caps csv
sbreitbart-NOAA ceabe80
Finished first working draft of add_more_key_quants fxn; updated alt …
sbreitbart-NOAA fb42b6d
Small updates to fix regex matching
sbreitbart-NOAA caf1b9f
added new fxn (add_more_key_quants) to plotting fxns
sbreitbart-NOAA 10a3a36
updated add_more_key_quants fxn to handle two units (arguments) speci…
sbreitbart-NOAA e3e61f6
minor update to test-plot_landings
sbreitbart-NOAA 2c8de34
-fixed bug in add_more_key_quants to allow str_replace_all to work ev…
sbreitbart-NOAA df15d98
coded more key quantities
sbreitbart-NOAA 523542d
started "manual" vignette
sbreitbart-NOAA 12327b7
Changed projected biomass csv entry from figure to table; updated key…
sbreitbart-NOAA ea6c439
Started updating manual with documentation for new fxn
sbreitbart-NOAA 7f6de5d
Finished updating new section in manual
sbreitbart-NOAA 7bae837
Updating F-related key quantities' calculations
sbreitbart-NOAA 63b0568
Update manual to emphasize importance of checking/editing alt text
sbreitbart-NOAA 1f01f5e
Updated calculation for landings plot's y axis max, since it's a stac…
sbreitbart-NOAA 1805490
Merge branch 'key-quants-2' of https://github.com/nmfs-ost/satf into …
sbreitbart-NOAA f1c8ad8
re-removed export_rda and extract_caps_alttext from utils R script (e…
sbreitbart-NOAA c4848f8
Updating quantities calculations and naming conventions as per meetin…
sbreitbart-NOAA 32c75e7
Uncommented key quantity-extracting code that didn't work for multipl…
sbreitbart-NOAA 2d42cf1
Extracted 2 more key quantities (min, max M rate)
sbreitbart-NOAA f004ea3
Update vignettes/manual.Rmd
sbreitbart-NOAA 156c705
Update vignettes/manual.Rmd
sbreitbart-NOAA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,4 @@ captions_alt_text.csv | |
converted_file_1126.csv | ||
rda_files | ||
petrale_sole_std_output.csv | ||
inst/doc |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever I use the str_replace_all fxn, I haven't identified the regex as one using the regex() function. Have you found this is necessary for the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested another regex option without stringr::regex. Would you recommend something different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I gotcha. I was just curious because I haven't had any issues with just using a regex there without making it explicit through that function