IChunkStream interface and post from stream #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go for it. We're all just rolling our own kludgy fixes for this issue at
the moment.
…On Sun, Feb 19, 2017 at 12:02 PM, Evgeny Mazovetskiy < ***@***.***> wrote:
when POST body is a big one, my spark core goes flashing red and reboots.
Unfortunately we don't have enough memory in this controller.
If you have already, for example a numeric array to send to your server,
you can build request body on the fly using smaller chunks, thus avoiding
out of memory error.
@nmattisson <https://github.com/nmattisson>, if you are intersted in the
further development of this library, I can commit an example of
ChunkStream. Also HttpClient::request methods need some refactoring I think.
------------------------------
You can view, comment on, or merge this pull request online at:
#36
Commit Summary
- IChunkStream interface and post from stream
File Changes
- *M* firmware/HttpClient.cpp
<https://github.com/nmattisson/HttpClient/pull/36/files#diff-0> (229)
- *M* firmware/HttpClient.h
<https://github.com/nmattisson/HttpClient/pull/36/files#diff-1> (9)
- *A* firmware/IChunkStream.h
<https://github.com/nmattisson/HttpClient/pull/36/files#diff-2> (12)
Patch Links:
- https://github.com/nmattisson/HttpClient/pull/36.patch
- https://github.com/nmattisson/HttpClient/pull/36.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#36>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHdubcgEKfH-kCDYe-fi4BHleoeDUodyks5reJHTgaJpZM4MFjkQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when POST body is a big one, my spark core goes flashing red and reboots. Unfortunately we don't have enough memory in this controller.
If you have already, for example a numeric array to send to your server, you can build request body on the fly using smaller chunks, thus avoiding out of memory error.
@nmattisson, if you are intersted in the further development of this library, I can commit an example of ChunkStream. Also HttpClient::request methods need some refactoring I think.