Invalid type for `on`

warning: unneeded late initialization --> crates/differ/src/lib.rs:140:4 | 140 | let diagonal_gap_cost: isize; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init = note: `#[warn(clippy::needless_late_init)]` on by default help: declare `diagonal_gap_cost` here | 141 | let diagonal_gap_cost: isize = if s1.chars().nth(j - 1).unwrap() == s2.chars().nth(i - 1).unwrap() { | ++++++++++++++++++++++++++++++ help: remove the assignments from the branches | 142 ~ char_match 143 | } else { 144 ~ not_char_match | help: add a semicolon after the `if` expression | 145 | }; | +

warning: the loop variable `j` is only used to index `dir_vector` --> crates/differ/src/lib.rs:131:11 | 131 | for j in 1..second_string_len + 1 { | ^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator | 131 | for <item> in dir_vector.iter_mut().skip(1).take(second_string_len) { | ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/differ/src/lib.rs:104:25 | 104 | 1.0 - self.similarity(&score) | ^^^^^^ help: change this to: `score` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: redundant clone --> crates/differ/src/levenshtein.rs:111:48 | 111 | let temp = get_operations(&dir_matrix, s2, s1).clone(); | ^^^^^^^^ help: remove this | note: this value is dropped without further use --> crates/differ/src/levenshtein.rs:111:13 | 111 | let temp = get_operations(&dir_matrix, s2, s1).clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone = note: `#[warn(clippy::redundant_clone)]` on by default

warning: the loop variable `j` is used to index `my_vec` --> crates/differ/src/levenshtein.rs:104:11 | 104 | for j in 0..left_str_len { | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator and enumerate() | 104 | for (j, <item>) in my_vec.iter_mut().enumerate().take(left_str_len) { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> crates/differ/src/levenshtein.rs:100:35 | 100 | pub(crate) fn my_init_vec(my_vec: &mut Vec<Vec<isize>>, top_str_len: usize, left_str_len: usize) { | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [Vec<isize>]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> crates/differ/src/levenshtein.rs:13:10 | 13 | my_opp: &Vec<Vec<char>>, | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec<char>]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> crates/differ/src/levenshtein.rs:4:47 | 4 | pub(crate) fn reverse_vec_and_indexes(my_vec: &mut Vec<StringDiffOp>, mut top_string_len: usize) { | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [StringDiffOp]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default