Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable not quoted can cause errors in other CMakefiles.txt #231

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

matmanc
Copy link
Contributor

@matmanc matmanc commented Oct 2, 2023

Because of an earlier change now in this CMakefile it is checked if the variable is defined. However, the variable is not properly escaped and it could cause issues.

Copy link
Contributor

@csbnw csbnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@csbnw csbnw added the bug Something isn't working label Oct 2, 2023
@matmanc matmanc merged commit 18cc587 into main Oct 2, 2023
3 checks passed
@matmanc matmanc deleted the fix_quoted_variable branch October 2, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants