-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add managed memory #211
Merged
Merged
Add managed memory #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few minor things:
|
@john-romein, |
matmanc
reviewed
Sep 20, 2023
csbnw
commented
Sep 20, 2023
csbnw
commented
Sep 20, 2023
matmanc
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are many ways to mix and match different types of CUDA memory. As preparation for this PR, an (performance) evaluation of different strategies was conducted, the findings are summarized below:
cu::HostMemory
andcu::DeviceMemory
with explicit memory copies provides the best performance, but is also the most verbose.With the changes in this MR, support for option 3 is added.
To be specific, the
cu::DeviceMemory
constructor can now also be used to allocate managed memory by passingCU_MEMORYTYPE_UNIFIED
asCUmemorytype
argument and optionally also some flags. This change is transparent to pre-existing code by havingCU_MEMORYTYPE_DEVICE
as the defaultCUmemorytype
and defaultflags = 0
.Additionally,
cu::Stream::memPrefetchAsync
is added to expose thecuMemPrefetchAsync
function.The new functionality is tested in new sections of the
test_vector_add
test.Related issues:
Instructions to review the pull request