Improve marker functionality and related dumpfile issues #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this to wait for any writing of markers to finish. Used when the dumping to file is stopped, and when the I/O thread is stopped. Sometimes a marker was written after closing the dump file. Check if the dumpfile is not nullptr both when writing a marker and when writing power data
loostrum
commented
Nov 15, 2024
The device now keeps track of markers to send with a counter instead of boolean When a second marker request is received before the first one is sent, both are now sent with consecutive samples of sensor 0
First wait for all markers to be processed, then wait for final packet to be sent to avoid missing last marker
This was
linked to
issues
Nov 18, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates in host library:
The default timeout when waiting for markers is 500 ms.
Still, sometimes the last marker is not written. Even with a 5s timeout this happens. To be debugged further in firmware: verify the marker is actually being sent. Perhaps the boolean flag in the firmware (should we send a marker?) can be replaced by a counter to avoid missing markers in quick succession.Firmware updates: