Switch to newer epubcheck and modules parent. #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpub
approved these changes
Jun 29, 2021
There was a problem hiding this comment.
Hi @kalaspuffar, and thank you very much for this fix. Does this mean that with this, the validator could be used together with the present state of the MTM Pipeline 2 edition?
|
Hi @martinpub Yes, it can be used, but the EPUBs will not be valid if generated in the pipeline. I have talked with @bertfrees about the issue and created an issue to describe the problem daisy/pipeline#612 Best regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @martinpub
This will solve the issue we had with not creating a correct XML document. This was because we have updated to the latest EPUBCheck in the pipeline.
I've updated to the latest EPUBCheck and the next to the latest version of the parent modules. Lastly, I've updated some namespaces to their new domains.
We are not changing to using the last version yet of pipeline modules because it will break the tests. The last version of the pipeline will not create valid EPUBs following the nordic guidelines. This could be good to keep in mind if you want to convert DTBooks to EPUB.
Best regards
Daniel