Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

story: 117304 implement openklant 2.0 #302

Merged

Conversation

anna-ritense
Copy link
Contributor

This PR makes it possible to connect the NL Portal backend to an OpenKlant 2.X.X instance and interface with Partijen, PartijIdentificatoren and DigitaleAdressen and in the future other paths of the Klantinteracties API of OpenKlant 2.0.

# Conflicts:
#	gradle/wrapper/gradle-wrapper.properties
# Conflicts:
#	gradle/wrapper/gradle-wrapper.properties
* fix integration tests not running on check/build
* remove unnecessary Create* dto's
* expand filtering with page
* refactored some functions and class names
* introduce initial DigitaleAdres related entities and queries
* disable sql logging for app
* fix DigitaleAdresType serialization
* add authentication requirement to all openklant queries and mutations
* add delete DigitaleAdres mutation
* change base integration test image
* integration tests for DigitaleAdres
* fixed integration test ordering in test classe where it matters
@anna-ritense anna-ritense linked an issue Oct 9, 2024 that may be closed by this pull request
@flinden68
Copy link
Collaborator

Zou het geen idee zijn om als je een partij ophaalt dat je in de graphQL query ook aan kan geven of je via expand andere resources ingeladen kan krijgen en dan vooral ook welke resources je ingeladen wilt hebben.

@anna-ritense
Copy link
Contributor Author

anna-ritense commented Oct 10, 2024

Dat had ik ook bedacht als een nice-to-have, alleen voor de huidige functionaliteit was het niet nodig.
De volgende methode uitbrijden met expand opties en null als een default lijk makkelijk te zijn. Alleen weet ik niet of het een goede idee is om de graphql query ook uit te breiden met dit. Ik wil niet dat de gebruiker alle informatie in zijn network tab in development tools ziet.
Wat denk jij @nielserkamp-ritense?

@anna-ritense anna-ritense marked this pull request as ready for review October 14, 2024 07:35
@anna-ritense anna-ritense merged commit b9d4773 into feature/117302-openklant-2.0 Oct 14, 2024
1 check passed
@anna-ritense anna-ritense deleted the story/117304-implement-openklant-2.0 branch October 14, 2024 07:35
@anna-ritense
Copy link
Contributor Author

anna-ritense commented Oct 14, 2024

Merged for now to avoid getting a stale PR. Any desired changes should be done to the feature branch with a PR before we merge it to the development branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement OpenKlant 2.0
2 participants