-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement OpenKlant 2.0 #196
Comments
@petervanmanenritense maybe we can develop it along the current code and return a getKlant, so there is also support for KVK and BSN. |
@flinden68 What is the current status of the issue? |
Not implemented yet. Needs to refined what is the impact. May be it is wise to implement a v2 flow, because a lot has changed. |
In de comments staat hoe je op basis van KVK of BSn je de klant (partij) op te halen. maykinmedia/open-klant#174 |
The scope for this was reduced to only provide support for existing functionality (to be able to replace the old openklant module). A client was set up so that other paths (such as klantcontact, betrokkene etc) can be added as the need for them arises. |
See https://github.com/nl-portal/nl-portal-frontend-libraries/tree/story/117304-implement-openklant-2.0 for an example on how to work with these queries. NB! bsn of burger user in keycloak needs to be changed to the one of the persoon partij in the openklant 2 instance from the docker-compose project for the contacts to show. |
@anna-ritense Change BSN in Keycloak for local development should be avoided as all the test data, also our mock data is based on these BSN's. Better way is to change the BSN in the docker-compose in the open klant 2 instance to the one are configured in Keycloak |
The problem is, the imports are internal to the openklant 2.0 image from maykin, so they can't easily be modified. I'd have to add new entries instead of modifying the existing base data. But I don't really have time to do that right now. |
With the release of Open Klant 2.0 we are facing a breaking change and needs to adapt accordingly.
For the new specification see https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/open-klant/2.0.0/src/openklant/components/klantinteracties/openapi.yaml
changes
The text was updated successfully, but these errors were encountered: