Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OpenKlant 2.0 #196

Closed
flinden68 opened this issue Mar 20, 2024 · 8 comments · Fixed by #302 or #348
Closed

Implement OpenKlant 2.0 #196

flinden68 opened this issue Mar 20, 2024 · 8 comments · Fixed by #302 or #348
Assignees
Labels
enhancement New feature or request

Comments

@flinden68
Copy link
Collaborator

With the release of Open Klant 2.0 we are facing a breaking change and needs to adapt accordingly.
For the new specification see https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/maykinmedia/open-klant/2.0.0/src/openklant/components/klantinteracties/openapi.yaml

changes

  • klant --> partij
  • contactmomenten --> klant contacten
@flinden68 flinden68 added the enhancement New feature or request label Mar 20, 2024
@flinden68
Copy link
Collaborator Author

@petervanmanenritense maybe we can develop it along the current code and return a getKlant, so there is also support for KVK and BSN.

@nielserkamp-ritense
Copy link
Contributor

@flinden68 What is the current status of the issue?

@flinden68
Copy link
Collaborator Author

Not implemented yet. Needs to refined what is the impact. May be it is wise to implement a v2 flow, because a lot has changed.

@flinden68
Copy link
Collaborator Author

In de comments staat hoe je op basis van KVK of BSn je de klant (partij) op te halen. maykinmedia/open-klant#174

@anna-ritense anna-ritense self-assigned this Oct 9, 2024
@anna-ritense anna-ritense linked a pull request Oct 9, 2024 that will close this issue
@anna-ritense
Copy link
Contributor

The scope for this was reduced to only provide support for existing functionality (to be able to replace the old openklant module). A client was set up so that other paths (such as klantcontact, betrokkene etc) can be added as the need for them arises.

@anna-ritense
Copy link
Contributor

See https://github.com/nl-portal/nl-portal-frontend-libraries/tree/story/117304-implement-openklant-2.0 for an example on how to work with these queries. NB! bsn of burger user in keycloak needs to be changed to the one of the persoon partij in the openklant 2 instance from the docker-compose project for the contacts to show.

@flinden68
Copy link
Collaborator Author

@anna-ritense Change BSN in Keycloak for local development should be avoided as all the test data, also our mock data is based on these BSN's. Better way is to change the BSN in the docker-compose in the open klant 2 instance to the one are configured in Keycloak

@anna-ritense
Copy link
Contributor

The problem is, the imports are internal to the openklant 2.0 image from maykin, so they can't easily be modified. I'd have to add new entries instead of modifying the existing base data. But I don't really have time to do that right now.
I'll note this down for later in the sprint.

@flinden68 flinden68 linked a pull request Jan 14, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants