generated from nl-design-system/example
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/typography scale #762
Open
Marwaxhello
wants to merge
6
commits into
main
Choose a base branch
from
feat/typography-scale
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+235
−222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Marwaxhello
force-pushed
the
feat/typography-scale
branch
from
October 22, 2024 13:38
2e7332e
to
ff456c3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
=======================================
Coverage 89.41% 89.41%
=======================================
Files 13 13
Lines 1049 1049
Branches 147 147
=======================================
Hits 938 938
- Misses 110 111 +1
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. |
Robbert
requested changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In deze PR heb ik de basis typography font-size scale toegevoegd aan de volgende themas:
De volgende was toegevoegd:
xx-small
t/mxxxx-large
nora.typography.font-size.md
⇒basis.typography.scale.medium.font-size
Issues
De NORA-tokens waren vanaf het begin ongedefinieerd. Bij nader onderzoek bleek dat het probleem lag bij de vw-sizing voor font-sizes. Utrecht bleek niet vertrouwd te zijn met deze aanpak en gebruikt deze niet standaard. Ik vond een PR van Rogier met een oplossing waarbij de small vw werd verwijderd. Ik heb deze fix toegepast (cherry-picked) en het basisthema geïmplementeerd, waarna het probleem was opgelost.
Vragen
In de typography scale van de NORA-tokens is er een extra maat (large2) tussen 'large' en 'xlarge' gezet, met slechts 1 pixel verschil. Deze wordt gebruikt op regel 2322. Wat is de beste aanpak hiervoor?