chore: format/lint .cjs and .mjs files #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matijs
force-pushed
the
chore/deal-with-cjs-files
branch
from
06ca043
to
703a002
Compare
matijs
changed the title
matijs
force-pushed
the
chore/deal-with-cjs-files
branch
from
703a002
to
f443546
Compare
|
@Robbert this adds quite a bit of config just for parsing an import assertion. We could also get rid of the assertion by using Node's |
Robbert
previously approved these changes
Apr 9, 2024
Merged
Make sure Prettier, ESLint and lint-staged know about .cjs and .mjs files Use `@babel/eslint-parser` to parse .cjs and .mjs files and allow the deprecated import assertions syntax (`assert`) for now.
matijs
force-pushed
the
chore/deal-with-cjs-files
branch
from
f443546
to
f5ebc19
Compare
bddjong
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure Prettier, ESLint and lint-staged know about .cjs and .mjs files