Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replaced dh badgecounter with utrecht badgecounter, added badge… #1570

Merged
merged 1 commit into from
Oct 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions components/BadgeCounter/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@gemeente-denhaag/badge-counter",
"version": "0.1.1-alpha.411",
"version": "0.3.0-alpha.411",
"description": "A Badge component",
"bugs": "https://github.com/nl-design-system/denhaag/issues",
"repository": {
Expand Down Expand Up @@ -30,8 +30,8 @@
"watch:components": "chokidar --silent --follow-symlinks \"src/**/*\" -c \"pnpm run build\""
},
"dependencies": {
"@gemeente-denhaag/dotindicator": "workspace:*",
"@utrecht/components": "6.1.0"
"@utrecht/component-library-react": "7.0.0",
"@utrecht/components": "7.3.0"
},
"peerDependencies": {
"react": "^18.0.0"
Expand Down
11 changes: 0 additions & 11 deletions components/BadgeCounter/src/index.scss
Original file line number Diff line number Diff line change
@@ -1,12 +1 @@
@import "~@utrecht/components/dist/badge-counter/css";

.denhaag-badge-counter {
--denhaag-dot-indicator-size: 8px;
}

.denhaag-badge-counter__counter {
@extend .utrecht-badge-counter;

font-family: var(--utrecht-badge-counter-font-family);
font-size: var(--utrecht-badge-counter-font-size);
}
23 changes: 2 additions & 21 deletions components/BadgeCounter/src/index.tsx
Original file line number Diff line number Diff line change
@@ -1,24 +1,5 @@
import React, { HTMLAttributes } from 'react';
import { DotIndicator } from '@gemeente-denhaag/dotindicator';
import { BadgeCounter, BadgeCounterProps } from '@utrecht/component-library-react';
import './index.scss';
import clsx from 'clsx';

export type BadgeCounterProps = HTMLAttributes<HTMLDivElement>;

/**
* A counter badge notifies a user of a specific amount of updates.
* @param props The properties of a Badge component.
* @constructor Constructs an instance of Badge.
*/
export const BadgeCounter: React.FC<BadgeCounterProps> = (props: BadgeCounterProps) => {
const rootClassNames = clsx('denhaag-badge-counter', props.className);
return (
<div id={props.id} className={rootClassNames}>
<DotIndicator overlap={'rectangle'}>
<div className={'denhaag-badge-counter__counter'}>{props.children}</div>
</DotIndicator>
</div>
);
};

export { BadgeCounter, BadgeCounterProps };
export default BadgeCounter;
1 change: 1 addition & 0 deletions components/Menu/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"watch:components": "chokidar --silent --follow-symlinks \"src/**/*\" -c \"pnpm run build\""
},
"dependencies": {
"@gemeente-denhaag/badge-counter": "workspace:*",
"@gemeente-denhaag/button": "workspace:*",
"@gemeente-denhaag/icons": "workspace:*",
"@gemeente-denhaag/language-switcher": "workspace:*",
Expand Down
7 changes: 7 additions & 0 deletions components/Menu/src/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@
}
}

.denhaag-mobile-menu-list-item-link-label {
display: flex;
flex-direction: row;
gap: var(--denhaag-mobile-menu-list-item-button-label-gap);
align-items: center;
}

.denhaag-mobile-menu-list-item-expanded-list {
display: var(--denhaag-mobile-menu-list-item-expanded-list-display);
list-style: var(--denhaag-mobile-menu-list-item-expanded-list-list-style);
Expand Down
13 changes: 11 additions & 2 deletions components/Menu/src/mobile/MobileMenu.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React, { HTMLAttributes, useState } from 'react';
import { BadgeCounter } from '@gemeente-denhaag/badge-counter';
import { SheetContainer } from '@gemeente-denhaag/sheet';
import { ArrowRightIcon, ChevronDownIcon, ArrowLeftIcon, LogOutIcon } from '@gemeente-denhaag/icons';
import { MobileMenuList } from './MobileMenuList';
Expand All @@ -11,11 +12,13 @@ import { Button } from '@gemeente-denhaag/button';

import useToggleState from './use-togglestate';
import clsx from 'clsx';
import MobileMenuLinkLabel from './MobileMenuLinkLabel';

interface NavigationGroupProps {
label: string;
href?: string;
navigation?: Array<NavigationGroupProps>;
badgeCounter?: number;
}

interface LogoutButtonProps {
Expand Down Expand Up @@ -61,7 +64,10 @@ const ExpandedListItem = ({ label, navigation, Link, scrollMenu, tabIndex }: Exp
return (
<MobileMenuListItem key={key}>
<MobileMenuLink Link={Link} href={l3Nav.href}>
<span>{l3Nav.label}</span>
<MobileMenuLinkLabel>
<span>{l3Nav.label}</span>
{l3Nav.badgeCounter && <BadgeCounter>{l3Nav.badgeCounter}</BadgeCounter>}
</MobileMenuLinkLabel>
<span className="denhaag-mobile-menu-list-submenu-list-item-link__icon">
<ArrowRightIcon />
</span>
Expand Down Expand Up @@ -91,7 +97,10 @@ const ExpandedList = ({ label, navigation, Link, scrollMenu, tabIndex }: Expande
return (
<MobileMenuListItem key={key}>
<MobileMenuLink Link={Link} href={l2Nav.href} tabIndex={tabIndex}>
<span>{l2Nav.label}</span>
<MobileMenuLinkLabel>
<span>{l2Nav.label}</span>
{l2Nav.badgeCounter && <BadgeCounter>{l2Nav.badgeCounter}</BadgeCounter>}
</MobileMenuLinkLabel>
<span className="denhaag-mobile-menu-list-submenu-list-item-link__icon">
<ArrowRightIcon />
</span>
Expand Down
16 changes: 16 additions & 0 deletions components/Menu/src/mobile/MobileMenuLinkLabel.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import React, { HTMLAttributes } from 'react';
import clsx from 'clsx';

export interface MobileMenuLinkLabelProps extends HTMLAttributes<HTMLDivElement> {}

export const MobileMenuLinkLabel = ({ className, children, ...props }: MobileMenuLinkLabelProps) => {
const classNames = clsx('denhaag-mobile-menu-list-item-link-label', className);

return (
<div {...props} className={classNames}>
{children}
</div>
);
};

export default MobileMenuLinkLabel;
1 change: 1 addition & 0 deletions packages/storybook/src/templates/util.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ export const headerProps: HeaderLogicProps = {
label: 'MijnDenHaag',
navigation: [
{ label: 'Overzicht', href: 'https://klantportaal.denhaag.nl/overzicht' },
{ label: 'Mijn berichten', href: 'https://klantportaal.denhaag.nl/berichten', badgeCounter: 3 },
{ label: 'Lopende zaken', href: 'https://klantportaal.denhaag.nl/zaken' },
{ label: "Thema's", href: 'https://klantportaal.denhaag.nl/themas' },
{ label: 'Mijn account', href: 'https://klantportaal.denhaag.nl/account' },
Expand Down
47 changes: 42 additions & 5 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions proprietary/Components/src/denhaag/menu.tokens.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@
"large": {
"font-size": { "value": "20px" },
"font-weight": { "value": "700" }
},
"label": {
"gap": { "value": "8px" }
}
}
},
Expand Down