Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Set for better performance #47

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use Set for better performance #47

wants to merge 1 commit into from

Conversation

graphemecluster
Copy link
Member

Perhaps?

@syimyuzya
Copy link
Member

I don't think a Set with just tens of elements at most would have a performance improvement that beats simplicity 🤔

However we probably do need reverse lookups for 呼韻搭配, 等母搭配 etc, so we can eliminate some for-loops in 音韻地位.驗證.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants