Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add naamning.js and naamningdingzi.js #37

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Conversation

leimaau
Copy link

@leimaau leimaau commented May 5, 2022

add naamning.js and naamningdingzi.js

@ayaka14732 ayaka14732 self-requested a review May 6, 2022 02:45
Copy link
Member

@ayaka14732 ayaka14732 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

應該要改埋 README 先至可以 detect 到呢兩個 file

@graphemecluster
Copy link
Member

建議用新加嘅 輕脣韻、括號同 運算子等等簡化 is 入面嘅運算式
同埋新方案建議 prefer is`…` over is('…')

@leimaau
Copy link
Author

leimaau commented May 6, 2022

@graphemecluster 新嘅語法格式api喺邊度搵?

@graphemecluster
Copy link
Member

@leimaau 呢度~
https://nk2028.shn.hk/qieyun-js/classes/____.html#__-6

@ayaka14732 (點解我會冇 Member badge。。。)

@ayaka14732
Copy link
Member

@graphemecluster 嗰個 ____.html 好搞笑 XD(我一開始就想改,但係唔知點改)

點解我會冇 Member badge。。。

?!

係咪 GitHub bug 咗

我試下將你 move out 再加返

@ayaka14732
Copy link
Member

ayaka14732 commented May 6, 2022

我都冇咗個 badge,所以 move out 應該冇用,唔理住先 😆

@graphemecluster
Copy link
Member

唔緊要,我唔介意嘅,我純粹見到就噏下㗎啫

@leimaau
Copy link
Author

leimaau commented May 6, 2022

新格式我試下淨「輕脣韻」可以用,其他未開啓,就噉先,等上線新語法我再調整。

Copy link
Member

@ayaka14732 ayaka14732 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 縮進應該統一 space 或者 tab,唔應該混用,最好用 2 個 space
  2. 「某攝 某等」呢種寫法可以改作「某韻」。「某攝 某等」呢種講法喺方言學入面多啲,但對於切韻音系嚟講就係「某韻」好睇啲

naamning.js Outdated Show resolved Hide resolved
Copy link
Member

@ayaka14732 ayaka14732 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果寫攝簡單啲,可以唔使改成韻

naamningdingzi.js Outdated Show resolved Hide resolved
Copy link
Member

@graphemecluster graphemecluster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我哋要確保 codebase 嘅品質,希望你唔好介意。
最好用 Prettier 之類嘅 formatter format 下,縮排之類就唔會錯啦。

naamning.js Outdated Show resolved Hide resolved
naamning.js Outdated Show resolved Hide resolved
naamning.js Outdated Show resolved Hide resolved
naamning.js Outdated Show resolved Hide resolved
naamning.js Outdated Show resolved Hide resolved
Copy link
Member

@graphemecluster graphemecluster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有冇條件加新舊派同文白讀開關?

@leimaau
Copy link
Author

leimaau commented May 8, 2022

@graphemecluster 應該可以,我試試過先,得就 pr 上來。

naamning.js Outdated Show resolved Hide resolved
naamning.js Outdated Show resolved Hide resolved
naamning.js Outdated Show resolved Hide resolved
naamning.js Outdated Show resolved Hide resolved
naamning.js Outdated Show resolved Hide resolved
naamning.js Outdated Show resolved Hide resolved
naamning.js Outdated Show resolved Hide resolved
naamning.js Outdated Show resolved Hide resolved
naamningdingzi.js Outdated Show resolved Hide resolved
naamningdingzi.js Outdated Show resolved Hide resolved
naamning.js Outdated Show resolved Hide resolved
@untunt untunt force-pushed the main branch 3 times, most recently from a50f6d6 to 1769033 Compare August 20, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants