Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cumulative bugs and add features #4

Merged
merged 54 commits into from
Apr 19, 2024
Merged

Fix cumulative bugs and add features #4

merged 54 commits into from
Apr 19, 2024

Conversation

ayaka14732
Copy link
Member

@ayaka14732 ayaka14732 commented Jun 19, 2021

  1. Implement more methods for 韻鏡位置
  2. Implement 韻鏡位置到音韻地位
  3. Implement 音韻屬性到韻鏡位置們
  4. Add __hash__ method and comparison methods
  5. Add 音韻地位到韻鏡位置, 韻鏡位置到音韻地位 and 音韻屬性到韻鏡位置們
  6. Add 音韻地位.is_normal
  7. Rename 開合皆有的韻 to 開合兼備的韻
  8. Add class 韻鏡位置
  9. Add 容錯 for 欣韻 and 眞韻
  10. Change 眞韻 to 真韻
  11. Change 欣韻 to 殷韻
  12. Move 元韻 to 山攝
  13. Change 母到清濁, 韻到攝, 母到音 and 母到組 to function
  14. Rename 正則化韻 to 韻目到韻
  15. Add 所有音, 所有組, 所有類 and 所有攝
  16. Add tests

@untunt untunt self-requested a review September 26, 2021 12:52
@ayaka14732
Copy link
Member Author

I am still working on it...

'銜 檻 狎',
'嚴 儼 釅㽉 業',
'銜 檻 鑑㽉 狎',
'嚴 儼广 釅驗 業',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Difference:

驗: 鹽 -> 嚴
㽉: 嚴 -> 銜

(I don't know)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

集韻:

鹽第二十四 琰第五十 豔第五十五 葉第二十九
沾第二十五 忝第五十一 栝第五十六 帖第三十
嚴第二十六 儼第五十二 驗第五十七 業第三十一
咸第二十七 豏第五十三 陷第五十八 洽第三十二
銜第二十八 檻第五十四 㽉第五十九 狎第三十三
凡第二十九 范第五十五 凡第六十 乏第三十四

There is more confusion between 鹽B and 嚴 in 集韻, so '驗' (廣韻鹽B) becomes 嚴 in 集韻

Copy link
Member Author

@ayaka14732 ayaka14732 Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a warning:

@ayaka14732
Copy link
Member Author

太久沒更新,完全記不清了,在舊的分支上改但是怕出錯,所以把舊的分支的 diff 留在這裏供參考:https://github.com/nk2028/qieyun-encoder-python/compare/98f075469af2d6c80fc62821b1383aea8feaebc4...feat-0.5.x-old?expand=1

@ayaka14732 ayaka14732 self-assigned this Apr 19, 2024
@ayaka14732 ayaka14732 marked this pull request as ready for review April 19, 2024 00:11
@ayaka14732 ayaka14732 merged commit c724f09 into main Apr 19, 2024
6 checks passed
@ayaka14732 ayaka14732 deleted the feat-0.5.x branch April 19, 2024 00:12
@ayaka14732 ayaka14732 restored the feat-0.5.x branch April 19, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants