-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder 廣韻字頭 and correct some 字 & 釋義 (WIP) #10
Draft
syimyuzya
wants to merge
20
commits into
main
Choose a base branch
from
feat-order-and-corrections
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 反切 now includes annotations for representing original and corrected forms - 音韻地位 updated accordingly - Every 小韻 now has a 音韻地位 TBD: - Fix 反切 in 釋義 and 釋義補充 - Add missing checks back
TBD: - Check 反切
Open
滂三A支平 → 滂三A脂平
nk2028 调整过小韵地位或反切的小韵中,《广韵形声考》对字头作了修正的如下:
这些应该收录。99 鈹小韵下「𤿎」也应一起改为「𢻹」 《广韵形声考》中其他对字头的修正由于不涉及 nk2028 对小韵的调整,可以暂缓收录 |
This is for ease of comparison with the new data
TBD: - Apply patches to _poem_'s data - Add rows missing in _poem_'s data
- All entries are reordered according to 澤存堂本 - This solves a long-standing issue with both 韻典 and 廣韻字音表's data: Both data tables combine 字頭 from 廣韻全字表 and 釋義 from 宋本廣韻データ. However 廣韻全字表 is based on 巾箱本 while 宋本廣韻データ is based on 澤存堂本, which creates mismatches. - Entries missing in poem's data are added back - This includes characters only representable with IDS, and seveval additions from 廣韻校本 - More errors in 字頭 & 釋義 are corrected - These were discovered when the new 字序表 was being made, and are still WIP.
- Marked 4 invalid 小韻s (597 𤜼, 646 𡰝, 2021 㶒, 3373 𣅝) - Added more checks on patches.csv
syimyuzya
force-pushed
the
feat-order-and-corrections
branch
from
January 23, 2025 03:50
fc24f64
to
45e7e2d
Compare
New corrections: - 141 𤿎<𢻹> - 646 𡰝<𡰖> (小韻 no longer invalid) - 2991 (2991a) 𣢝<欦>
Was CRLF, should be LF.
ytenx_流水序 is the 序號 on the character's page (or in the page's URL after `/kyonh/dzih/`).
The columns of 字序表.csv has changed, so the load (and check) script in build.py should be updated accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
注意:本 PR 依賴 #8
TODO: