refactor: 用户权限重构；新增工具类；拆分原项目实体类（未完成） #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilingj
reviewed
Feb 13, 2023
|
|
||
| REVIEW_INTERNSHIP_APPLICATION(11, "实习申请审核人", "有权利通过/退回实习申请"), | ||
| REVIEW_PATENT_APPLICATION(12, "专利申请审核人", "有权利通过/退回专利申请"), | ||
| REVIEW_REIMBURSE_APPLICATION(13, "报销申请审核人", "有权利通过/退回报销申请"), |
|
|
||
| @RestControllerAdvice | ||
| @Slf4j | ||
| public class CommonExceptionConfig { |
There was a problem hiding this comment.
这个组件放到config包下面，包括下面的拦截器。还要考虑和现存的全局异常捕捉/拦截器是否有冲突
| var token_map = encryptorComponent.decrypt(token); | ||
| request.setAttribute("uid", token_map.get("uid")); //塞入 用户id | ||
| request.setAttribute("aid", token_map.get("aid")); //塞入 用户权限值 | ||
| // var token_map = encryptorComponent.decrypt(token); |
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Integer id; | ||
| @ManyToOne | ||
| @JoinColumn(name = "user_id") | ||
| User user; | ||
| UserPo user; | ||
| //状态 -1审核不通过，0审核中，1审核通过 | ||
| int state; |
There was a problem hiding this comment.
看到好多类似的状态，后面重构的时候可以考虑抽出去，做一个枚举，代码层面上赋予语义
| * @param map | ||
| */ | ||
| @AccessPermission(PermissionEnum.EDIT_ANY_USER_INFO) |
| * @return | ||
| */ | ||
| @GetMapping("/v2/user/permission") | ||
| public CommonResult<List<PermissionResp>> getPermissions(@RequestAttribute int uid){ |
There was a problem hiding this comment.
新的代码可以先放到新的类里面，比如UserControllerV2，老的先加个@deprecated，后续确保没有问题再删除或者禁用
|
|
||
| @GetMapping("/v2/user/team") | ||
| public CommonResult<List<TeamResp>> getTeams(@RequestAttribute int uid){ |
| CreateEventRequest.CreateEventRequestReminders reminder = new CreateEventRequest.CreateEventRequestReminders() | ||
| .setMethod("dingtalk") | ||
| .setMinutes(60); | ||
| CreateEventRequest.CreateEventRequestEnd end = new CreateEventRequest.CreateEventRequestEnd() | ||
| .setDateTime(get_ISO0861_Time(dingTalkSchedule.getEnd())) | ||
| .setDateTime(get_ISO0861_Time(dingTalkSchedulePo.getEnd())) |
perf: dc汇总表格新增两列.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.