refactor: 用户权限、身份、组关系重构 #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilingj
requested changes
Feb 7, 2023
| * @param uid | ||
| * @return | ||
| */ | ||
| @GetMapping("/user/permission") |
| * @return | ||
| */ | ||
| @GetMapping("/user/permission") | ||
| public List<String> getPermissions(@RequestAttribute int uid){ |
There was a problem hiding this comment.
写一个通用返回类CommonResult，所有返回值都用这个类包裹
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private int id; | ||
|
|
||
| private String name; |
| /** | ||
| * 用户权限id（代替authority） | ||
| */ | ||
| private int permissionId; |
There was a problem hiding this comment.
一个用户可以属于多个权限组，一个权限组有多个权限，用户应该有所属组的所有权限。这里应该是list
There was a problem hiding this comment.
另：设置一层直接对应数据库表的对象，比如UserPo，PermissionPo，mapper层负责直接增删改查这些对象，repo层调用mapper层读取Po对象，将Po对象转换组装成Entity，提供给service使用，或者将Entity拆散成Po，调用mapper层写入。
|
|
||
| @Override | ||
| public int hashCode(){ | ||
| return userId+permissionId; |
There was a problem hiding this comment.
-
- 两边加空格
- userId * 10000 + permissionId是不是好一点
| private int teamId; | ||
|
|
||
| @Override | ||
| public boolean equals(Object obj){ |
There was a problem hiding this comment.
代码相似，可以考虑
- 抽取代码，使用设计模式设计一下（模版方法啥的）
- 我不知道JPA里有联合主键这个概念，有的话可以考虑单独新建一个包，专门放这种类，增加代码可读性
| * @param userId | ||
| * @return 所有权限名 | ||
| */ | ||
| public List<String> getPermissionNames(int userId){ |
There was a problem hiding this comment.
像上面说的，可以分离PO对象和Entity对象，Repository层使用Po组装Entity时，就可以把权限对象转换成枚举，放到Entity里去，不用写这些混乱的东西。
There was a problem hiding this comment.
用枚举代替String，String缺少语意，且含混不清，到底是用名字，还是用id？不如从repo中出来的时候就统一转换成枚举
|
|
||
| #-------------------- 用户模块新增的表 -----------------------# | ||
| drop table if exists team; | ||
| create table `team` |
There was a problem hiding this comment.
使用create table if not esists team可能好一点，这个会把原有数据删掉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
重构了部分用户权限，用户所在科研组的代码