nix::fcntl add FcntlArg::F_READAHEAD for freebsd. #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
fbsd_fcntl_readahead
branch
from
f4c08e4 to
154d9a0
Compare
SteveLauC
reviewed
Dec 23, 2024
test/test_fcntl.rs
Outdated
Comment on lines
815
to
818
| // With TMPDIR set with UFS, the vnode name is not entered | ||
| // into the name cache thus path is always empty. | ||
| // Therefore, we reopen the tempfile a second time for the test | ||
| // to pass. |
There was a problem hiding this comment.
Why would an empty path fail our test?
There was a problem hiding this comment.
ah nvm I think this is copy paste from another test..
| /// Set or clear the read ahead amount for sequential access or | ||
| /// disable it with 0 or to system default for any value < 0. | ||
| #[cfg(target_os = "freebsd")] | ||
| F_READAHEAD(c_int), |
There was a problem hiding this comment.
Is this something related to the kernel page cache, something used to control the pre-fetch strategy?
There was a problem hiding this comment.
it manages file data caching yes. will adjust the comment.
devnexen
force-pushed
the
fbsd_fcntl_readahead
branch
from
154d9a0 to
2f9ecee
Compare
Set/clear the amount of read ahead for the file descriptor.
devnexen
force-pushed
the
fbsd_fcntl_readahead
branch
from
2f9ecee to
ad7bd99
Compare
SteveLauC
approved these changes
Dec 24, 2024
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set/clear the amount of read ahead for the file descriptor.