MapFlags netbsd/freebsd constant additions. #2090
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
mmap_update_bsd
branch
2 times, most recently
from
8713927 to
204de8d
Compare
asomers
requested changes
Aug 26, 2023
src/sys/mman.rs
Outdated
| #[cfg_attr(docsrs, doc(cfg(all())))] | ||
| MAP_ALIGNMENT_64PB; | ||
| /// Right operand value for the page alignment bitshift calculation | ||
| /// FIXME: not present in libc for FreeBSD |
There was a problem hiding this comment.
Why don't you go ahead and add defines for these on FreeBSD (and maybe other places) in libc before merging this PR into Nix?
There was a problem hiding this comment.
These 2 constants have been added in libc#3326
SteveLauC
requested changes
Nov 29, 2023
| @@ -184,6 +184,40 @@ libc_bitflags! { | |||
| #[cfg(target_os = "openbsd")] | |||
| #[cfg_attr(docsrs, doc(cfg(all())))] | |||
| MAP_CONCEAL; | |||
| /// Pages aligned on 64kb | |||
| #[cfg(target_os = "netbsd")] | |||
| #[cfg_attr(docsrs, doc(cfg(all())))] | |||
There was a problem hiding this comment.
Please rebase and remove the #[cfg_attr(docsrs, doc(cfg(all())))] attributes from all the variants as we have removed them all from the codebase (#2192)
src/sys/mman.rs
Outdated
| #[cfg_attr(docsrs, doc(cfg(all())))] | ||
| MAP_ALIGNMENT_64PB; | ||
| /// Right operand value for the page alignment bitshift calculation | ||
| /// FIXME: not present in libc for FreeBSD |
There was a problem hiding this comment.
These 2 constants have been added in libc#3326
devnexen
force-pushed
the
mmap_update_bsd
branch
from
effe44d to
ffaa1a9
Compare
Related to page alignment, adding map_aligned for custom alignment requirements.
devnexen
force-pushed
the
mmap_update_bsd
branch
from
ffaa1a9 to
e351bfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to page alignment, adding map_aligned for custom alignment requirements.