Fix vscodium shell to work like nvim shell. #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike the nvim shell, the vscodium shell didn't specify any nixd server settings, so the example `flake.nix` didn't work. Fixed this by: - Pulling vscodium's user settings.json into a separate file, and filling it with the same contents as the config elaborated in nvim-lsp.nix. - Moved dev shell generation in the nixd repo's `flake.nix` to a common `mkDevShell` function for both nvim and vscodium (since the `settings.json` is sepecific to the hardcoded `/tmp/NixOS_Home-Manager` path.) Ideally we'd read the nixd server settings from the same file for both nvim and vscodium, but I don't know Lua so I didn't want to touch it.
inclyc
reviewed
Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the nvim shell, the vscodium shell didn't specify any nixd server settings, so the example
flake.nixdidn't work. Fixed this by:Pulling vscodium's user settings.json into a separate file, and filling it with the same contents as the config elaborated in nvim-lsp.nix.
Moved dev shell generation in the nixd repo's
flake.nixto a commonmkDevShellfunction for both nvim and vscodium (since thesettings.jsonis sepecific to the hardcoded/tmp/NixOS_Home-Managerpath.)Ideally we'd read the nixd server settings from the same file for both nvim and vscodium, but I don't know Lua so I didn't want to touch it.