Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix concurrency bug by locking cout #351

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

NaN-git
Copy link

@NaN-git NaN-git commented Feb 13, 2025

Output lines of differents thread can be intertwined. Granting mutual access to std::cout fixes this.

@Mic92
Copy link
Member

Mic92 commented Feb 13, 2025

@mergify queue

Copy link
Contributor

mergify bot commented Feb 13, 2025

queue

🛑 The pull request has been removed from the queue default

Pull request #351 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Mic92
Copy link
Member

Mic92 commented Feb 13, 2025

@mergify dequeue

Copy link
Contributor

mergify bot commented Feb 13, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #351 has been dequeued by a dequeue command

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link
Contributor

mergify bot commented Feb 13, 2025

dequeue

✅ The pull request has been removed from the queue default

@Mic92 Mic92 merged commit 6d4fd5a into nix-community:main Feb 13, 2025
24 of 25 checks passed
@Ericson2314
Copy link
Contributor

Thanks @NaN-git!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants